Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-editors/vscodium: add loong support #39424

Merged
merged 2 commits into from
Nov 23, 2024
Merged

app-editors/vscodium: add loong support #39424

merged 2 commits into from
Nov 23, 2024

Conversation

xen0n
Copy link
Member

@xen0n xen0n commented Nov 23, 2024

Following upstream support.

Please check all the boxes that apply:

  • I can submit this contribution in agreement with the Copyright Policy.
  • I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @xen0n
Areas affected: ebuilds
Packages affected: app-editors/vscodium

app-editors/vscodium: @AdelKS, @arthurzam, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Nov 23, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-11-23 09:09 UTC
Newest commit scanned: 3057ed2
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/e8c77e3/output.html#global

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e8c77e3/output.html

arthurzam
arthurzam approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@arthurzam arthurzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase, it should fix the broken CI (it not by you of course)
Feel free to merge when you want :)

xen0n added a commit to xen0n/gentoo that referenced this pull request Nov 23, 2024
@xen0n
app-editors/vscodium: keyword 1.95.3.24321-r1 for ~loong
6e20e39 
Signed-off-by: WANG Xuerui <xen0n@gentoo.org>
Reviewed-by: Arthur Zamarin <arthurzam@gentoo.org>
Closes: gentoo#39424
@xen0n xen0n marked this pull request as ready for review November 23, 2024 13:40
xen0n added 2 commits November 23, 2024 21:54
@xen0n
app-editors/vscodium: add loong to SRC_URI
4422f56 
After VSCodium/vscodium#2121 loong became
supported, and upstream has retroactively appended loong artifacts
to the 1.95.3.24321 release.

Signed-off-by: WANG Xuerui <xen0n@gentoo.org>
Reviewed-by: Arthur Zamarin <arthurzam@gentoo.org>
@xen0n
app-editors/vscodium: keyword 1.95.3.24321-r1 for ~loong
fe32fe2 
Signed-off-by: WANG Xuerui <xen0n@gentoo.org>
Reviewed-by: Arthur Zamarin <arthurzam@gentoo.org>
Closes: gentoo#39424
@gentoo-bot gentoo-bot merged commit fe32fe2 into gentoo:master Nov 23, 2024
@xen0n xen0n deleted the vscodium-loong branch November 23, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurzam arthurzam arthurzam approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xen0n @gentoo-bot @gentoo-repo-qa-bot @arthurzam