Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this will fix an issue that has ocurred during the initial start of the #588

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

ltclm
Copy link
Contributor

@ltclm ltclm commented Dec 19, 2023

service container in the infra vhost environment. After a scan for orphaned indexes the container (running in service mode) tried to remove orphaned indexes on EFS which was mounted read-only on the host.

in service mode (as backend for search wsgi)
the service-sphinxsearch container needs read-only access to the EFS

in maintenance mode (triggered by data deploy on geodatasync) the service-sphinxsearch container needs read-write access to the EFS

with this change the clean-up of orphaned indexes in the EFS will be done only in maintenance mode, during the sphinx index createion.

this will allow us to strictly mount the geodata efs in read-only mode on all our kubernetes or infra vhosts instances.

@ltclm ltclm requested a review from rebert December 19, 2023 21:09
@github-actions github-actions bot added the bug label Dec 19, 2023
@ltclm ltclm requested a review from ltshb December 19, 2023 21:09
service container in the infra vhost environment. After a scan for
orphaned indexes the container (running in service mode) tried to remove
orphaned indexes on EFS which as mounted read-only on the host.

in service mode (as backend for search wsgi)
the service-sphinxsearch container needs read-only access to the EFS

in maintenance mode (triggered by data deploy on geodatasync)
the service-sphinxsearch container needs read-write access to the EFS

with this change the clean-up of orphaned indexes in the EFS will be
done only in maintenance mode, during the sphinx index createion.

this will allow us to strictly mount the geodata efs in read-only mode on all
our kubernetes or infra vhosts instances.
Copy link
Contributor

@rebert rebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@ltclm ltclm merged commit 8682c10 into master Dec 20, 2023
9 checks passed
@ltclm ltclm deleted the fix_sphinx_efs_permissions branch December 20, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants