-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functions returning Box types now return None types instead of Geometry types #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 0.9.0 broke my code. My query was returning a string from Box2D(), since version 0.9.0 the call to Box2D() gets wrapped by ST_AsEWKB. This change fixes my problem so I can get a string back from Box2D().
from geoalchemy2 import Geometry
from sqlalchemy.orm import scoped_session, sessionmaker
from sqlalchemy import func
session = scoped_session(sessionmaker())
stmt = session.query(func.ST_Dump(Geometry()).label("x")).subquery()
print(session.query(func.Box2D(stmt.c.x.geom))) |
Hi @EdwardBetts |
adrien-berchet
requested changes
Mar 18, 2022
Will do |
Co-authored-by: Adrien Berchet <adrien.berchet@gmail.com>
adrien-berchet
changed the title
Fix to stop Box2D being wrapped with ST_AsEWKB
Functions returning Box types now return None types instead of Geometry types
Mar 19, 2022
Thanks @EdwardBetts , I updated a few other functions for consistency, does it look good to you? |
adrien-berchet
approved these changes
Mar 19, 2022
Looks good to me. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 0.9.0 broke my code. My query was returning a string from Box2D(), since version 0.9.0 the call to Box2D() gets wrapped by ST_AsEWKB. This change fixes my problem so I can get a string back from Box2D().