Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support const generic buffers #661

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Support const generic buffers #661

merged 3 commits into from
Jul 18, 2024

Conversation

kylebarron
Copy link
Member

@kylebarron kylebarron commented Jul 18, 2024 •
edited
Loading

This is initial work to support 3d/4d geometries in geoarrow-rs!

Change list

  • Add const generic dimension parameter to coordinate buffers and scalars.
  • For now, high-level geometry arrays are still 2D, but this opens up opportunities to parametrize the buffer dimension

For #662

@kylebarron kylebarron enabled auto-merge (squash) July 18, 2024 21:17
@kylebarron kylebarron merged commit 38e3ca0 into main Jul 18, 2024
21 checks passed
@kylebarron kylebarron deleted the kyle/const-generic-buffers branch July 18, 2024 21:19
@kylebarron kylebarron mentioned this pull request Jul 18, 2024
Closed
11 tasks
@kylebarron kylebarron mentioned this pull request Aug 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kylebarron