Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlatGeobuf 3d support #728

Merged
merged 14 commits into from
Oct 9, 2024
Merged

FlatGeobuf 3d support #728

merged 14 commits into from
Oct 9, 2024

Conversation

kylebarron
Copy link
Member

@kylebarron kylebarron commented Aug 27, 2024

Change list

  • Use geo-traits implementation from Implement geo-traits on Flatgeobuf geometry objects #779
  • Make a couple fixes in the geo-traits.
    • Offsets were coordinate offsets and need to be multiplied by 2 to get the correct x and y values
    • Lengths are end - start
    • I was computing the number of linestrings in multi line strings incorrectly.
  • Add more tests on the Python side.

@kylebarron
Copy link
Member Author

This isn't working yet, I think it's because I'm going through geozero, and it's unclear whether the issue is on my side or geozero's side. It may be better to first update to use geo-traits for parsing geometries: #818

@kylebarron
Copy link
Member Author

kylebarron commented Oct 9, 2024

Now the geo-traits are piped through, but there's something not working on the read side. It looks like it's working for points. So if I had to guess, it's probably that the geo-traits are incorrectly implemented for polygons.

We should add tests with linestring and polygon data to see which geometry types pass.

image

@kylebarron kylebarron enabled auto-merge (squash) October 9, 2024 05:44
@kylebarron kylebarron merged commit d4e6957 into main Oct 9, 2024
23 checks passed
@kylebarron kylebarron deleted the kyle/flatgeobuf-3d branch October 9, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant