Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize wfs-client #3

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Modernize wfs-client #3

merged 1 commit into from
Oct 23, 2018

Conversation

tusbar
Copy link
Contributor

@tusbar tusbar commented Oct 23, 2018

  • Use yarn instead of npm [sorry]
  • Use xo instead of custom eslint config
  • Use async/await
  • Upgrade libxmljs
  • Require node > 8
  • Remove superagent and use got
    • Let got concat each buffer chunk instead of doing it manually
    • Get rid of the double callback! warnings

This change fixes some issues where errors would be swallowed. For example, http://geobretagne-migration.fr/geoserver/rff/wfs used to throw a Version negociation failed error while the error was in fact that the DNS doesn’t resolve.

@tusbar tusbar self-assigned this Oct 23, 2018
@tusbar tusbar requested a review from jdesboeufs October 23, 2018 14:45
@@ -8,7 +8,6 @@ A very simple WFS client
* Version negociation
* Service identification in plain JavaScript / JSON
* List all feature types
* Based on [Q promises](https://github.com/kriskowal/q)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤪

@tusbar tusbar merged commit 92b8258 into master Oct 23, 2018
@tusbar tusbar deleted the tusbar/modernize branch October 23, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants