-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
require SUNDIALS and deal.II 9.5 #5367
Conversation
b056e94
to
5751694
Compare
I would prefer if we can combine this change with the switch to requiring deal.II 9.5. That way users will only have to install a new deal.II version once. The first step for that would be to start a new reference tester with 9.5 and include that in the CI. |
Sure. :-) |
We need for deal.II packaging of 9.5 to finish first... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve now already, even though I know that this shouldn't yet be merged.
It would probably be nice (here or in a follow-up) to also output SUNDIALS version information in source/global.cc
in the print_aspect_header()
function in the same way as we do for the other dependencies.
What's our timeline for this? |
soonish. the only missing piece is to switch our reference tester results to the new 9.5 tester. |
b5ca51b
to
e42d5a2
Compare
e42d5a2
to
eedc2eb
Compare
ca4e745
to
1fd4cd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @bangerth ?
I am not sure if we should delay merging this a bit further, but it would be great to have this in place at some point so we can start merging features requiring it and so we can test installation instructions, CI, etc..