tune performance #222
Merged
tune performance #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if False: | ||
| r=timeit.timeit('__main__.test_grueneisen()', setup="import __main__", number=3) | ||
| print("test_grueneisen", r) |
There was a problem hiding this comment.
Timo, why do we skip this? And keep it in?
There was a problem hiding this comment.
I used this for testing if my changes had a positive impact. I agree it is not great to have it in here as is. I will update it.
- jit some functions
- add misc/performance.py with several checks
This patch increases performance from:
4331518 function calls (4024502 primitive calls) in 6.741
seconds
to
3574686 function calls (3263157 primitive calls) in 4.139
seconds
|
okay, updated. |
Merged
|
Looks good to me. |
| return 1./6./nu_o_nu0_sq * (2.*f+1.) * ( a1_ii + a2_iikk*f ) | ||
|
|
||
| @jit | ||
| def _delta_pressure_fast1(V_0, a1_ii, a2_iikk, x, Debye_0): |
There was a problem hiding this comment.
This function seems mis-named. Perhaps _debye_temperature_fast?
|
Looks good to me, thanks! |
ian-r-rose
added a commit
that referenced
this pull request
Jan 5, 2016
- jit some functions - add misc/performance.py with several checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch increases performance from:
4331518 function calls (4024502 primitive calls) in 6.741
seconds
to
3574686 function calls (3263157 primitive calls) in 4.139
seconds