Initial logging implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
geoff-imdex
commented
Oct 2, 2024
geoff-imdex
commented
- Modified code from r2r / ros2_rust PR 371
- Replaced log creation to use rcl_logging_configure to allow us to push to /rosout
- TODO:
-
- Add support for full featured macros, e.g. throttling, once, etc
-
- Don't force users to have logging
-
- Support use/setting of rosout_enabled
imdexsam
reviewed
Oct 2, 2024
imdexsam
reviewed
Oct 4, 2024
* Modified code from r2r / ros2_rust PR 371 * Replaced log creation to use rcl_logging_configure to allow us to push to /rosout * TODO: * * Add support for full featured macros, e.g. throttling, once, etc * * Don't force users to have logging * * Support use/setting of rosout_enabled
geoff-imdex
force-pushed
the
ros2_rust_log_support
branch
from
2b5f111 to
48cb2e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.