-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve password storage #1
Comments
Looks like the but the suggested fix of re-signing the virtualenv's python binary seems to solve the problem. |
I've had a bash at implementing this in a branch: https://github.com/gkluoe/git2jss/compare/keychain It tries to do The Right Thing and defaults to using the keychain. If it finds a password in the plist file (left by an older version), it will offer to move it into the keychain and if the user refuses, will only operate if the '--no-keychain' option is specified. |
I decided it's probably better to use our own plist file for git2jss, rather than using the default. This keeps things neater. Due to what I think is a bug in |
Fix issue #1 by supporting local keychain storage via the `keyring` module
Currently, the default behaviour is to store the JSS credentials in a plain text file (the python-jss module's preferences file). It would be much better to integrate with keychain, or at least allow an option to prompt for a password every time.
The text was updated successfully, but these errors were encountered: