fix: do not rewrite /api and /data-api requests to SvelteKit #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-desert-00b80111e-162.westus2.2.azurestaticapps.net |
|
One of the E2E tests is being flaky. Not sure why, but manually recreating it passes. |
geoffrich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145.
Previously, the
'*'rule in the SWA config would catch all POST/PUT/DELETEs and redirect them to the SvelteKit app, even those to external Azure functions. This PR adds"/api/*"and"/data-api/*"routes to the config so that those routes are not rewritten to the SvelteKit app.I added an external function to the demo app and a E2E test. This makes the "demo" setup slightly more complicated, but I think it's fine.