Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify dimensions of mfdataset match weight table #5

Closed
rileyhales opened this issue Aug 3, 2023 · 2 comments · Fixed by #6
Closed

Verify dimensions of mfdataset match weight table #5

rileyhales opened this issue Aug 3, 2023 · 2 comments · Fixed by #6

Comments

@rileyhales
Copy link
Collaborator

There should be a way to check that the dimensions of the weight table match the dimensions the weight table was generated for. May need additional arguments to the function, a naming convention for the csvs, etc. Whatever you decide to do should have documentation given in the readme and docstrings
@RickytheGuy
Copy link
Collaborator

I'm not sure quite what you mean by that first sentence. are you talking about how the weight table names contain the dimensions of the input runoff datasets?

@rileyhales
Copy link
Collaborator Author

No the dimensions of the arrays. The weight table name contains the resolution of the grid it was generated from. the size of the array that xarray gets should be the same.

@RickytheGuy RickytheGuy mentioned this issue Aug 8, 2023
Merged
@rileyhales rileyhales linked a pull request Aug 10, 2023 that will close this issue
Github Actions; Preliminary Documentation #6
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Github Actions; Preliminary Documentation RickytheGuy/rapid_inflows
2 participants
@rileyhales @RickytheGuy