Github Actions; Preliminary Documentation #6
Conversation
|
we don't have to do it in this PR but we should consider also having a single netcdf with hourly data for a few days and test reading inflows and aggregating up to daily or some other time step. |
|
fixes #4 -> this is my implementation of inputing multiple weight tables. Added tests to verify these results as well |
.github/workflows/test.yml
Outdated
| workflow_dispatch: | ||
| branches: | ||
| - rapid-inflows | ||
| [push, pull_request, workflow_dispatch] |
There was a problem hiding this comment.
i would be ok with on pull request or workflow_dispatch. Do you think we need to do it on every push?
There was a problem hiding this comment.
I don't think it is neccesary. It's nice since it automatically tests every push, but workflow_dispatch could make it obsolete since we can run the test whenever we want. If you want me to remove it I can
|
fixes #5 -> function now checks if weight table dims match the dataset dims. Info provided in readme about naming conventions |
fixes #2 -> test data added and github actions set up
Refs #3 -> some documentation done, readme added