Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Races not appearing when inside Relivent Permission level folders #96

Closed
Zarhog opened this issue Sep 12, 2024 · 11 comments
Closed

Races not appearing when inside Relivent Permission level folders #96

Zarhog opened this issue Sep 12, 2024 · 11 comments

Comments

@Zarhog
Copy link

Zarhog commented Sep 12, 2024

will make git hub later but the Races are not showing up even though they are in the correct compendium and folder

image

@geoidesic
Copy link
Owner

Off the top of my head I don't think it supports subfolders in the permission folders. Can you try move human up a level so that it's just in the Member's folder directly?

@geoidesic geoidesic changed the title Raaces not appearing when inside Relivent Permission level folders Races not appearing when inside Relivent Permission level folders Sep 13, 2024
@Zarhog
Copy link
Author

Zarhog commented Sep 17, 2024

This works in the Members folder directly.

we had the same issue in testing when first making the modual with class.

it would appear that calss and subclass was fixed to work, but Background and Race was not.

@geoidesic
Copy link
Owner

Yeah I think you are getting confused. I can't replicate this behaviour.

Subfolders within membership folders have never been supported. They don't work, not even for Class & Subclass. So is this a new feature request?

@geoidesic
Copy link
Owner

Unless I'm losing my marbles! I'll have another look later

@Zarhog
Copy link
Author

Zarhog commented Sep 18, 2024

??? i specifically remember having to have a long conversation when making the module as to why it was needed, and we even went over classes in particular. ???

@Zarhog
Copy link
Author

Zarhog commented Sep 18, 2024

if we dont have the modual also be able to seach subfolders ( and other folders under that) then it makes the managment of the compendiums that much harder.

@geoidesic
Copy link
Owner

I do vaguely remember this. Are you sure it’s working for classes and subclasses? I tried that this morning and it didn’t seem to be.

@geoidesic
Copy link
Owner

geoidesic commented Sep 18, 2024

I tested it again, it's not working for classes nor subclasses either. So this was never implemented. I'll implement it now.

@geoidesic
Copy link
Owner

geoidesic commented Sep 18, 2024

So... what about items in a compendium that are not in a folder at all when there are DT folders? – i.e. root level items? Should we assume those are:

  1. only for the GM
  2. available to everyone

?

@geoidesic
Copy link
Owner

You haven't answered this question, so I'm going to make an assumption that they should be available to everyone.

@geoidesic
Copy link
Owner

I actually think you previously answered this question on Discord... this is the problem with posting it on Discord – it doesn't get tracked against the issue, so.... all those moments, will be lost in time, like tears, in rain...

geoidesic added a commit that referenced this issue Sep 19, 2024
#96 - fix for Donation Tracker plugin to respect subfolders
geoidesic added a commit that referenced this issue Sep 19, 2024
* main:
  v1.5.3 #96 - fix for Donation Tracker plugin to respect subfolders
  v1.5.3

# Conflicts:
#	dist/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants