Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updatedb made fast #259

Merged
merged 1 commit into from
Oct 27, 2023
Merged

updatedb made fast #259

merged 1 commit into from
Oct 27, 2023

Conversation

adityapatadia
Copy link
Contributor

@adityapatadia adityapatadia commented Oct 8, 2023 •
edited
Loading

  • This will also reduce RAM usage as streams are used and files are not read as a whole.

@adityapatadia adityapatadia mentioned this pull request Oct 8, 2023
Closed
@adityapatadia
Copy link
Contributor Author

@bluesmoon this makes updatedb very fast while reducing RAM usage. Please consider merge and if possible release version.

@adityapatadia
Copy link
Contributor Author

@bluesmoon apologies for pinging u again but this is critical for us to get out. Can you please look into merging this?

@bluesmoon bluesmoon merged commit 3d9e902 into geoip-lite:main Oct 27, 2023
1 check passed
@adityapatadia
Copy link
Contributor Author

@bluesmoon thanks for merging. When you release, you might also want to change repo description. It won't work with node 0.6 anymore. Minimum version required should be node 12.

@bluesmoon
Copy link
Collaborator

Got it. Been meaning to do that.

Trallp pushed a commit to privateJets/node-geoip that referenced this pull request Mar 6, 2024
@adityapatadia @Trallp
updatedb made fast (geoip-lite#259)
24b8dae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluesmoon bluesmoon bluesmoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adityapatadia @bluesmoon