Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix distance field #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions lib/geokit-rails/acts_as_mappable.rb
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,24 @@ def geokit_finder_adapter
end

def within(distance, options = {})
origin = extract_origin_from_options(options)
units = extract_units_from_options(options)
formula = extract_formula_from_options(options)

options[:within] = distance

# Add bounding box to speed up SQL request.
bounds = formulate_bounds_from_distance(
options,
normalize_point_to_lat_lng(options[:origin]),
options[:units] || default_units)
with_latlng.where(bound_conditions(bounds)).
where(distance_conditions(options))

distance_column_name = distance_sql(origin, units, formula)

with_latlng
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Metrics/LineLength: Line is too long. [93/80]

.where(bound_conditions(bounds))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

.where(distance_conditions(options))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

end
alias inside within

Expand Down Expand Up @@ -154,9 +164,9 @@ def by_distance(options = {})
units = extract_units_from_options(options)
formula = extract_formula_from_options(options)
distance_column_name = distance_sql(origin, units, formula)
with_latlng.order(
Arel.sql(distance_column_name).send(options[:reverse] ? 'desc' : 'asc')
)
with_latlng
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Metrics/LineLength: Line is too long. [93/80]

.order(Arel.sql(distance_column_name).send(options[:reverse] ? 'desc' : 'asc'))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Metrics/LineLength: Line is too long. [89/80]

end

def with_latlng
Expand Down