Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mantra dataset #110

Merged
merged 46 commits into from
Dec 24, 2024
Merged

Mantra dataset #110

merged 46 commits into from
Dec 24, 2024

Conversation

levtelyatnikov
Copy link
Collaborator

I belive will need one more update considering new loader

Checklist

  • My pull request has a clear and explanatory title.
  • My pull request passes the Linting test.
  • I added appropriate unit tests and I made sure the code passes all unit tests. (refer to comment below)
  • My PR follows PEP8 guidelines. (refer to comment below)
  • My code is properly documented, using numpy docs conventions, and I made sure the documentation renders properly.
  • I linked to issues and PRs that are relevant to this PR.

Description

Issue

Additional context

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@levtelyatnikov
Copy link
Collaborator Author

There is some error with mantra_orientation dataset

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 92.63804% with 12 lines in your changes missing coverage. Please review.

Project coverage is 89.64%. Comparing base (04f9665) to head (45a9bb3).
Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
topobenchmark/data/datasets/mantra_dataset.py 93.54% 4 Missing ⚠️
topobenchmark/data/utils/io_utils.py 91.30% 4 Missing ⚠️
topobenchmark/utils/config_resolvers.py 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   89.51%   89.64%   +0.13%     
==========================================
  Files         126      129       +3     
  Lines        3518     3678     +160     
==========================================
+ Hits         3149     3297     +148     
- Misses        369      381      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@levtelyatnikov levtelyatnikov merged commit 58083bd into main Dec 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants