Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data module refactorization + new Optimizer module #75

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Data module refactorization + new Optimizer module #75

merged 5 commits into from
Jun 7, 2024

Conversation

gbg141
Copy link
Collaborator

@gbg141 gbg141 commented Jun 7, 2024

  • data module cleaning and refactorization. Now datasetsmodule is within data
  • New optimizer module that manages optimizers and schedulers, full compatibility with torch.optim

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.

Project coverage is 61.95%. Comparing base (a091a44) to head (468cd95).
Report is 1 commits behind head on main.

Files Patch % Lines
topobenchmarkx/optimizer/optimizer.py 66.66% 8 Missing ⚠️
topobenchmarkx/optimizer/base.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   61.83%   61.95%   +0.11%     
==========================================
  Files          95       98       +3     
  Lines        2361     2389      +28     
==========================================
+ Hits         1460     1480      +20     
- Misses        901      909       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbg141 gbg141 merged commit 140c222 into main Jun 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants