Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: captions + update for latest pydata-sphinx-theme #175

Merged
merged 2 commits into from
Aug 15, 2021

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Apr 3, 2021

This updates for the latest version of the theme (eg we were still using the variable names of the unreleased version, and those were changed).
Further, it also makes use of some new features.

One of them is that we can now have captions in the sidebar. @darribas I seem to remember that you initially wanted this when we made the docs (but at that time I said that the theme didn't yet support it, but would so in the future). I am only not sure what would be useful distinctions. What I tried out now gives:

image

Do we want something like that? (right now, the "reference guide" is a bit duplicated between the caption and the actual link ..)

@darribas
Copy link
Collaborator

darribas commented Apr 5, 2021

Thanks! this looks great!

I vaguely remember I mentioned the use of captions to single out the API docs from the guides. Maybe we can use "USER GUIDES" and "API REFERENCE"?

I'd be happy to merge at any point if you think it's good to go.

@martinfleis
Copy link
Member

This looks good to go!

@martinfleis martinfleis merged commit b4ca3e4 into geopandas:master Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants