Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for new tile values from Stamen #189

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Update tests for new tile values from Stamen #189

merged 1 commit into from
Oct 11, 2021

Conversation

darribas
Copy link
Collaborator

@darribas darribas commented Oct 9, 2021

This makes tests pass locally at least

@darribas darribas requested a review from martinfleis October 9, 2021 17:28
martinfleis
martinfleis approved these changes Oct 9, 2021
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly what is going on, Stamen is now giving the same pixels but as a png of a lower zoom level but a double resolution. Interesting.

@darribas darribas merged commit 6d479a6 into geopandas:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darribas @martinfleis