Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: enforce deprecation of version keyword in to_parquet/to_feather #3334

Merged
merged 1 commit into from
Jun 9, 2024
Merged

CLN: enforce deprecation of version keyword in to_parquet/to_feather #3334

merged 1 commit into from
Jun 9, 2024

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche mentioned this pull request Jun 9, 2024
Open
19 tasks
m-richards
m-richards approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@m-richards m-richards left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! - should we have a changelog entry for expiring this?

@jorisvandenbossche jorisvandenbossche merged commit 0157e0a into geopandas:main Jun 9, 2024
20 checks passed
@jorisvandenbossche jorisvandenbossche deleted the remove-parquet-version-deprecation branch June 9, 2024 13:35
@jorisvandenbossche
Copy link
Member Author

should we have a changelog entry for expiring this?

whoops, only saw you comment after seeing the green approval tick and merging it ;) Added this to #3335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-richards m-richards m-richards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisvandenbossche @m-richards