-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add basic support for data layer metadata IO #237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering: does GDAL only support setting it on the layer object? Or could it also be set on the dataset object?
GDAL appears to support reading / writing at the dataset or layer level, and seems to keep track of which was used (so they roundtrip). This means we probably should pass this in as |
Needs a merge of main. I was initially wondering if we should given one of both (probably the layer metadata) the "preference" and use plain |
Adding |
@jorisvandenbossche @martinfleis looks like we might be running into an auth issue with CircleCI that is coming from the GeoPandas organization level? Perhaps an expired personal access token? I don't recall that we specifically set up CircleCI for pyogrio. |
That's probably caused by #243 and I believe will resolve once merged? |
Sorry, you can ignore the Circle CI failure. That's indeed from #243, I enabled Circle CI to try building linux arm wheels there (we use CircleCI for that in shapely). But since that's not yet working, will disable it again. |
Resolves #218
Helps support GeoPandas #2777 and #2850
GDAL silently ignores attempts to write metadata when not supported by the underlying driver.
The output of
read_info(...)
now includes ametadata
key with the dict of metadata from the data layer (or None); note that depending on the driver, there may be metadata read even if not written. E.g., the metadata of a shapefile can be{'DBF_DATE_LAST_UPDATE': '2023-04-02'}
.I did not add
metadata
toread
because it didn't seem useful there./cc @DahnJ