REF: factor out dataset and layer creation for ogr_write #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is one failing build with GDAL main, but that's being addressed in #353 |
|
Thanks! |
pyogrio/_io.pyx
Outdated
| object layer_kwargs, bint promote_to_multi=False, bint nan_as_null=True, | ||
| bint append=False, dataset_metadata=None, layer_metadata=None, | ||
| gdal_tz_offsets=None | ||
| cdef create_dataset_layer( |
There was a problem hiding this comment.
Can you please add a minimal docstring to this to indicate it returns a boolean to indicate that a new layer is created in the process (vs append to existing), that it sets ogr_dataset and ogr_layer pointers with valid objects on success and raise exceptions otherwise, and that it is then the responsibility of the caller to release those?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just moves the setting up of the ogr dataset and layer objects for writing into a separate helper function, which should help with #346