Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v3 #207

Merged
merged 174 commits into from
Dec 5, 2024
Merged

feat: v3 #207

merged 174 commits into from
Dec 5, 2024

Conversation

oterral
Copy link
Collaborator

@oterral oterral commented Jan 26, 2024 •
edited
Loading

BREAKING CHANGES: Make mbt closer to openlayers and maplibre api

How to

Open the review app and test everything

Others

  • It's not a hack or at least an unauthorized hack :).
  • The images added are optimized.
  • Everything in ticket description has been fixed.
  • The author of the MR has made its own review before assigning the reviewer.
  • The title means something for a human being and follows the conventional commits specification.
  • The title contains [WIP] if it's necessary.
  • Labels applied. if it's a release? a hotfix?
  • The new class' members & methods are well documented
  • Tests added.

@vercel Vercel
Copy link

vercel bot commented Jan 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mobility-toolbox-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 11:03am

friedjoff
friedjoff approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@friedjoff friedjoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better now overall! 🚀

Let me know if I should look at anything in more detail. 👀

danji90
danji90 requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@danji90 danji90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Friedjoff, looks a lot better now. There are still a couple of bugs I found when testing the review app though. Please check

src/ol/controls/RoutingControl.ts Show resolved Hide resolved
doc/public/static/examples/ol-maplibre-layer.js Show resolved Hide resolved
@danji90
chore: update MIGRATION-V3.md (#209)
7cf0b57 
* chore: update MIGRATION-V3.md

* chore: clean

* chore: update ol-realtime.html
danji90
danji90 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@danji90 danji90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugs are fixed and code looks good. LGTM

@oterral oterral merged commit f2836aa into master Dec 5, 2024
8 checks passed
@oterral oterral deleted the v3 branch December 5, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danji90 danji90 danji90 approved these changes

@friedjoff friedjoff friedjoff approved these changes

Assignees

@oterral oterral

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oterral @friedjoff @danji90