-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFS 2.0 URL building #612
WFS 2.0 URL building #612
Conversation
This Pull Request has been inactive for 90 days. In order to manage maintenance burden, it will be automatically closed in 7 days. |
Pull request rebased onto latest master branch and all tests passing. The coveralls check is failing - it reports -0.006% coverage change, but I don't think this is correct - the changes in this pull requests are tested as previously. It also reported -0.2% on another run with the same code. I ran into a similar issue on MapServer with small changes between runs. We increased the threshold to 1% to avoid this (see MapServer/MapServer#6223). Maybe OWSLib is also required to have 60% coverage? |
In WFS 2.0 GetFeature requests currently fail for MapServer URLs containing
?map=path/my.map&
This is the same issue as #533 - and unfortunately I missed that there was also an open pull request at #534 from @samtux
The approach in this pull request is slightly different - it reuses the
build_get_url
function from utils.A few other notes:
owslib\util.py:561: DeprecationWarning: cgi.parse_qsl is deprecated, use urllib.parse.parse_qsl instead
so this has been updateddoseq
and URLs with ampersands