Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ISO 19115 Part 3 XML #933

Merged
merged 43 commits into from
Sep 20, 2024
Merged

Conversation

vjf
Copy link
Contributor

@vjf vjf commented Dec 31, 2023

Overview - Support for ISO 19115 Part 3 XML

This PR contains a new profile for pycsw, called 'iso19115p3'.

  • The profile is in 'pycsw\pycsw\plugins\profiles\iso19115p3', this includes a new outputschema
  • There is a new file 'mdb/py' in 'pycsw/pycsw/core' that contains classes used to parse the XML.
  • There is a unit test for 'mdb.py' in 'pycsw\tests\unittests\test_mdb.py'
  • There are function tests in 'pycsw\tests\functionaltests\suites\mdb'

Related Issue / Discussion

Additional Information

Contributions and Licensing

(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute ISO 19115 Part 3 support for pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
  • I have already previously agreed to the pycsw Contributions and Licensing Guidelines

@tomkralidis tomkralidis reopened this May 11, 2024
@kalxas
Copy link
Member

kalxas commented May 12, 2024

CI is still failing I see

@vjf
Copy link
Contributor Author

vjf commented May 13, 2024

@kalxas @tomkralidis All fixed. Thanks.

@kalxas
Copy link
Member

kalxas commented May 13, 2024

@vjf thank you.
We will review and come back with comments

@giohappy
Copy link

giohappy commented Jul 8, 2024

We're planning to upgrade PyCSW for GeoNode and one of the compelling reasons is the support for ISO 19115 Part 3.
Did you plan to merge this before the release of PyCSW 3?

@kalxas I take the opportunity to ask if you have a timeline for the release of PyCSW 3.

@tomkralidis
Copy link
Member

@kalxas let's review during this week's OGC Sprint.

Copy link
Member

@tomkralidis tomkralidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience @vjf -- an excellent piece of work here! See change requests.

Additional comment: the directory tests/functionaltests/suites/mdb is better renamed to tests/functionaltests/suites/iso19115p3.

tests/functionaltests/suites/cite/data/cite.db Outdated Show resolved Hide resolved
pycsw/core/config.py Show resolved Hide resolved
pycsw/core/config.py Outdated Show resolved Hide resolved
pycsw/core/repository.py Outdated Show resolved Hide resolved
pycsw/core/repository.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@tomkralidis tomkralidis added this to the 3.0.0 milestone Aug 4, 2024
@vjf
Copy link
Contributor Author

vjf commented Aug 12, 2024

@tomkralidis @kalxas All fixed.

@tomkralidis
Copy link
Member

@vjf sorry for the delay; it seems I added some final comments to this PR but they were not submitted.

We are fine with adding the extra columns for vertical extent (min and max), but prefer that that the funder column be managed outside of pycsw as an extra column. Once this is updated, I'll merge this PR -- great work again!

@vjf
Copy link
Contributor Author

vjf commented Sep 20, 2024

@tomkralidis @kalxas Removed 'Funder' as requested. Thanks.

@tomkralidis tomkralidis merged commit b556ed5 into geopython:master Sep 20, 2024
2 of 3 checks passed
@tomkralidis
Copy link
Member

Thanks @vjf, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants