Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign nil geometries to obs with malformed coordinates (#1922) #1923

Merged

Conversation

mikemahoney218-usgs
Copy link
Contributor

@mikemahoney218-usgs mikemahoney218-usgs commented Feb 5, 2025

Overview

This PR changes the CSV provider to not skip observations with malformed geometries, instead assigning them a point geometry with nil coordinates.

Related Issue / discussion

Fixes #1922

Additional information

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@tomkralidis tomkralidis self-requested a review February 8, 2025 16:25
@tomkralidis tomkralidis added the OGC API - Features OGC API - Features label Feb 8, 2025
@tomkralidis tomkralidis added this to the 0.20.0 milestone Feb 8, 2025
@tomkralidis tomkralidis merged commit 1d592ae into geopython:master Feb 8, 2025
3 checks passed
@mikemahoney218-usgs mikemahoney218-usgs deleted the malformed_geometries branch February 10, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OGC API - Features OGC API - Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should the CSV provider not skip invalid coordinates, and instead return nil geometries?
2 participants