Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont ignore empty values in createEqualsClauseRequest() (#672) #673

Merged
merged 1 commit into from
Sep 12, 2022
Merged

dont ignore empty values in createEqualsClauseRequest() (#672) #673

merged 1 commit into from
Sep 12, 2022

Conversation

landryb
Copy link
Member

@landryb landryb commented Aug 18, 2022

where foo='' and bar='blah' wont give the same results as where bar='blah'. - Fixes #672 but needs careful testing.

@landryb
dont ignore empty values in createEqualsClauseRequest() (georchestra#672
f7b11d6 
)

where foo='' and bar='blah' wont give the same results as where bar='blah'.
@landryb
Copy link
Member Author

landryb commented Aug 18, 2022

when i say 'needs careful testing' lots of other places uses createEqualsClauseRequest and i have no idea if the other callers get an empty parameter value (if the user doesn't specify one) by default or not.

@MaelREBOUX
Copy link
Member

Well : this PR should do the job. Ok for merge and then testing.

@landryb landryb merged commit 0e99537 into georchestra:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrejego pierrejego Awaiting requested review from pierrejego

@Gaetanbrl Gaetanbrl Awaiting requested review from Gaetanbrl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getParcelle with empty ccopre might return results from a prefixed section
2 participants
@landryb @MaelREBOUX