Added port so that the service-name of static is independent #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks for the contribution ! |
changed to .env so we can use FQDN to config docker-compose.override …yml itself
|
Second change (about the .env) was meant to be in a different pull request. It should address #219 |
|
Bonjour François,
You're welcome. I do use gitlab but never github. So I messed up trying to
make 2 different Pull Requests.
I´m inclined to delete the messed-up-version, and try again.
What do you think?
Merci d'avance, Huub
|
|
Yes sure, go ahead. Thanks ! |
|
hello @hpwjnijs did you have time to split the PR :)? thank you |
|
I will close this PR, and make 2 new ones for the unrelated issues. |
This was referenced May 17, 2024
|
Hi Emilien,
Yes, I (just) did. Thanks for asking: I use gitlab a lot not github, but I
somehow managed.
Cheers, Huub
Op di 14 mei 2024 om 10:58 schreef Emilien Devos ***@***.***>:
… hello @hpwjnijs <https://github.com/hpwjnijs> did you have time to split
the PR :)? thank you
—
Reply to this email directly, view it on GitHub
<#278 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARUCKF5TYHSF5MWBGH3566DZCHG3PAVCNFSM6AAAAABFOH6B7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZGY2TGMRQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So traefik sees the 'static' service as static-<directory>@docker and that how it is addressed. But you want to have it directory independant. There is no direct way to name/label your service , but according to this you can fix this by e.g.
So, that's what we do here.
It fixes #214