Add download step #243
Open
Add download step #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added another fix to use downloaded jdk for jlink |
|
Can you please separate this into two PRs @albfan ? These changes are pretty unrelated and I'm not sure the JAVA_HOME bit will work in all cases. |
|
We can do a better fallback for jlink. About Split, what is it? split by OS? |
|
The two commits. I'm not sure if adding the JAVA_HOME/... bit will work with the CI scripts. |
albfan
force-pushed
the
install-instructions
branch
from
92b6372
to
6e2209c
Compare
|
hmm, yes, that change don't make much sense and is unrelated with fix. Not sure why I needed, jlink is resolvable in my PATH |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #242