Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest textmate grammar from redhat-developer/vscode-java #289

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Silic0nS0ldier
Copy link

Copied from https://github.com/redhat-developer/vscode-java/blob/70ebc3eec19f0e827734b9a20f016e92433c834d/language-support/java/java.tmLanguage.json, which is what the VSCode integrated Java textmate grammar uses.

This grammar covers many more language features (e.g. multi-line text blocks).

Differences I can see (not all shown in the screenshots) are;

  • Annotations are now consistently colored and use the same color as class and interface declaration names.
  • true/false/null colors now match that of other languages (now blue where before it was light green).
  • The static class property class is now colored the same as normal properties (I'd personally classify this as a regression since the prior grammar explicitly classifies it as keyword.class, although this seems more like an opinion).
  • Many more (but not all) variables/fields/properties are colored.

There are likely plenty more differences. If a more exhaustive comparison is desired let me know and I'll get the current and proposed extensions running side-by-side (its a bit of work right now as 2 fully functional environments are required, doable but tedious).

Current

image

VSCode Builtin (Red Hat)

image

PR

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant