Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect filename in config #465

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rryk
Copy link

@rryk rryk commented Mar 5, 2024

Fixes issue #464

@skysyk
Copy link

skysyk commented Mar 25, 2024

@georgezhao2010 please review, thank you!

@wuwentao
Copy link

@rryk
@wuchu
@skysyk

as current repo is not active more than 6 months.
I have forked it and consider to maintain it in futuer.
https://github.com/wuwentao/midea_ac_lan

PR is welcome

Thanks

@rryk
Copy link
Author

rryk commented May 21, 2024

I don't see hacs.json in your forked repo, so not sure if my pull request is applicable. On the other hand, I see my fix in diff on master...wuwentao:midea_ac_lan:master. Not sure why the file is gone though. Maybe it was removed in some later commit and that doesn't show in that view.

Either way, thanks for picking this up. I've installed the integration manually by checking out my own fork on the device, but I don't have the time to maintain it (accept pull requests and such), so glad that you do :-).

@wuwentao
Copy link

I don't see hacs.json in your forked repo, so not sure if my pull request is applicable. On the other hand, I see my fix in diff on master...wuwentao:midea_ac_lan:master. Not sure why the file is gone though. Maybe it was removed in some later commit and that doesn't show in that view.

Either way, thanks for picking this up. I've installed the integration manually by checking out my own fork on the device, but I don't have the time to maintain it (accept pull requests and such), so glad that you do :-).

Why you don't see hacs.json in diff:
as most of the PR in current repo try to fix this input error, and we have fixed it in https://github.com/wuwentao/midea_ac_lan
so you can directly access it and check the file, it should be exist and already have right value now
in additional, there is too many code changes by python-black and python-isort code format tool, also fixed python flake8 with old source code, you can check the detail in my repo about the changes.
now it should be more script checks rule in new fork.

you can continue use your fork if you don't need any new update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants