feat: Add support for unnest with lateral join #309
Conversation
statement_binder_context.py
| alias_name = self.visit(ctx.uid()) | ||
| column_list = [] | ||
| if ctx.uidList(): | ||
| column_list = self.visit(ctx.uidList()) |
There was a problem hiding this comment.
I feel it becomes harder over time to figure out which visit function it actually calls. Any idea to improve the readability?
There was a problem hiding this comment.
It is actually quite intuitive, thanks to antlr.
self.visit(ctx.uidList()) -> visitUidList
There was a problem hiding this comment.
I see it is somehow in the _insert_statements.py. I missed it.
|
|
||
| self.assertEqual(unnest_batch, expected) | ||
|
|
||
| def test_should_raise_error_with_missing_alias_in_lateral_join(self): |
There was a problem hiding this comment.
So JOIN LATERAL much have AS. However, it seems from https://github.com/georgia-tech-db/eva/blob/3c16181b140bc3b8cd26e99212d73f14a479ba30/eva/binder/statement_binder.py#L281 , when the node does not have alias, it will use the default node name and column name.
There was a problem hiding this comment.
Yes, I have added the code to handle it. But later felt that avoiding it, for now, is better. We can later remove the check from the parser and test it more.
No description provided.