feat: Explain command support #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you @gaurav274 give a proofread of current implementation from parser to statement before I go to the optimizer? As we discussed, the explainable statement/operator/plan will always be embedded as an attribute in the current design. |
xzdandy
reviewed
Oct 31, 2022
| @@ -75,6 +76,10 @@ def _bind_abstract_expr(self, node: AbstractExpression): | |||
| for child in node.children: | |||
| self.bind(child) | |||
|
|
|||
| @bind.register(ExplainStatement) | |||
| def _bind_explain_statement(self, node: ExplainStatement): | |||
| self.bind(node.explainable_stmt) | |||
There was a problem hiding this comment.
Right now, bind will create catalog entries. @gaurav274 This can be a consideration to move catalog operations to executors.
I think the idea of the current implementation works. |
Closed
gaurav274
approved these changes
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
EXPLAINsupport in the system.