feat: lateral function call to linear data flow #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gaurav274
commented
Dec 16, 2022
gaurav274
commented
- A simpler and easier-to-understand pipeline
- Reduce need for special case handling in the execution engine
- Simpler implementation for supporting reuse and ray due to the lack of branching.
gaurav274
changed the title
xzdandy
reviewed
Dec 18, 2022
| def apply(self, before: LogicalJoin, context: OptimizerContext): | ||
| # LogicalJoin(Lateral) LogicalApplyAndMerge | ||
| # / \ -> | | ||
| # A LogicalFunctionScan A |
There was a problem hiding this comment.
Can we directly create the new operator (LogicalApplyAndMerge --- A) from the statement? I can see the current implementation requires few code modification. Does this transformation have any other benefits?
There was a problem hiding this comment.
I considered doing it. However, I feel that will require adding a lot more core. Via rules, it is easier to understand the changes, and we can fallback to lateral join whenever needed. What do you think?
There was a problem hiding this comment.
I can not think of any issues right now. We need to make sure that this rule applies first, because I assume all later rewrite rules (such as UDF reuse) will base on the new linear design.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.