-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: catalog improved file and function names #544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a text document to list the Catalog objects with their purpose.
Any reason for this refactoring?
The original names were confusing. We were using dataset/metadata/table interchangeably. |
@@ -20,16 +20,16 @@ | |||
from eva.catalog.models.base_model import BaseModel | |||
|
|||
|
|||
class DataFrameMetadata(BaseModel): | |||
__tablename__ = "df_metadata" | |||
class TableCatalog(BaseModel): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a curious comment about model in general. Why do we add a catalog suffix for all models?
To me, catalog includes everything (udf, index, etc). Would this naming give a wrong impression that we maintain different catalogs for different models? (Again, just curious, don’t need a fix).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I referred Postgres. They also call each model as different catalog. https://www.postgresql.org/docs/current/catalog-pg-class.html.
What do you think? Maybe I'm wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. It seems like they use something like pg_{...}
as their naming convention? I didn't really see they use catalog
as suffix.
No description provided.