feat: support key-value cache for function expressions #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[WIP] UDF Reuse
…ed to rewrite_rules
jiashenC
reviewed
Jan 30, 2023
| from eva.utils.logging_manager import logger | ||
|
|
||
|
|
||
| class UdfHistoryColumnService(BaseService): |
There was a problem hiding this comment.
Can you elaborate when is this needed?
There was a problem hiding this comment.
This is from the older code. Will remove it
jiashenC
reviewed
Mar 28, 2023
xzdandy
reviewed
Mar 29, 2023
xzdandy
reviewed
Mar 29, 2023
xzdandy
reviewed
Mar 29, 2023
xzdandy
reviewed
Mar 29, 2023
jiashenC
reviewed
Mar 29, 2023
jarulraj
approved these changes
Mar 30, 2023
|
|
||
| reuse_batch = execute_query_fetch_all(select_query) | ||
| self._verify_reuse_correctness(select_query, reuse_batch) | ||
|
|
There was a problem hiding this comment.
Do we want to also check the time speedup with reuse?
There was a problem hiding this comment.
Might lead to a flaky test.
xzdandy
reviewed
Mar 30, 2023
xzdandy
reviewed
Mar 30, 2023
| results[cache_miss] = cache_miss_results.to_numpy() | ||
|
|
||
| # 5. return the correct batch | ||
| cols = [obj.name for obj in self.output_objs] |
There was a problem hiding this comment.
Duplicate code at line 193.
xzdandy
reviewed
Mar 30, 2023
|
|
||
| results = np.full([len(batch), len(cols)], None) | ||
| keys = batch | ||
| if self._cache.key: |
There was a problem hiding this comment.
When I first read code, I was thinking this is the key of the cache store. Maybe add a comment. This is to optimize the key for the function expression (data -> id).
xzdandy
approved these changes
Mar 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support added for caching when the UDF is in the
lateral join