Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Array_Count to ArrayCount #584

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Rename Array_Count to ArrayCount #584

merged 3 commits into from
Feb 13, 2023

Conversation

LordDarkula
Copy link
Collaborator

  • ArrayCount matches Python naming convention
  • This change should not be polluting the UDF registration PR

kaushikravichandran
kaushikravichandran approved these changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@kaushikravichandran kaushikravichandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did just renaming stuff reduce coverage by 0.2%?
Looks good otherwise.

@LordDarkula LordDarkula merged commit 898fc7d into georgia-tech-db:master Feb 13, 2023
@jarulraj jarulraj mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikravichandran kaushikravichandran kaushikravichandran approved these changes

@gaurav274 gaurav274 Awaiting requested review from gaurav274

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LordDarkula @kaushikravichandran