Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fuzzy Join support in EVA #589

Merged
merged 28 commits into from
Mar 18, 2023
Merged

feat: Fuzzy Join support in EVA #589

merged 28 commits into from
Mar 18, 2023

Conversation

ashmitaraju
Copy link
Collaborator

@ashmitaraju ashmitaraju commented Feb 17, 2023 •
edited
Loading

This PR

  • Introduces support for Fuzzy joins in EVA
  • It is implemented as a UDF but uses a nested loop join executor that can be generalized to nested loop joins in the future
  • Covers binder, optimizer and executor
  • Uses Levenshtein distance to calculate distance

gaurav274
gaurav274 requested changes Feb 23, 2023
View reviewed changes
eva/executor/fuzzy_join_executor.py Outdated Show resolved Hide resolved
eva/udfs/ndarray/fuzzy_join.py Outdated Show resolved Hide resolved
test/integration_tests/test_fuzzy_join.py Show resolved Hide resolved
gaurav274
gaurav274 reviewed Mar 10, 2023
View reviewed changes
Copy link
Member

@gaurav274 gaurav274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the name FuzzyJoin

gaurav274
gaurav274 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@gaurav274 gaurav274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments and we are good to go

eva/optimizer/rules/rules.py Show resolved Hide resolved
@gaurav274 gaurav274 self-requested a review March 10, 2023 23:22
@gaurav274
Copy link
Member

You need to check the failing test cases before merging. Thanks!

@ashmitaraju ashmitaraju reopened this Mar 16, 2023
@gaurav274 gaurav274 merged commit 0f725b9 into master Mar 18, 2023
@gaurav274 gaurav274 deleted the ashmita/fuzzy-join branch March 18, 2023 19:59
@jarulraj jarulraj mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikravichandran kaushikravichandran Awaiting requested review from kaushikravichandran

@gaurav274 gaurav274 Awaiting requested review from gaurav274

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashmitaraju @gaurav274 @kaushikravichandran