Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Adding CatalogManager, INSERT and DELETE documentation #595

Merged
merged 10 commits into from
Mar 16, 2023
Merged

doc: Adding CatalogManager, INSERT and DELETE documentation #595

merged 10 commits into from
Mar 16, 2023

Conversation

aryan-rajoria
Copy link
Collaborator

@aryan-rajoria aryan-rajoria commented Feb 24, 2023 •
edited
Loading

Documentation for CatalogManager, INSERT and DELETE operations

  • Add CREATE TABLE in insert documentation

@aryan-rajoria aryan-rajoria changed the title doc: Adding Catalog manager documentation doc: Adding CatalogManager, INSERT and DELETE documentation Feb 24, 2023
kaushikravichandran
kaushikravichandran reviewed Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@kaushikravichandran kaushikravichandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PNG seems too rigid. Is there a way to visualize and generate it using the sqlalchemy objects in the code? Something like this: https://github.com/sqlalchemy/sqlalchemy/wiki/SchemaDisplay?

kaushikravichandran
kaushikravichandran previously requested changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@kaushikravichandran kaushikravichandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add information about the udf_cost_catalog as well?
Ref: #588

@gaurav274
Copy link
Member

Add script and we should merge this. Thanks!

@gaurav274
Copy link
Member

Could you add information about the udf_cost_catalog as well? Ref: #588

@kaushikravichandran You can add that as part of your PR. Thanks!

@aryan-rajoria aryan-rajoria marked this pull request as ready for review March 15, 2023 18:27
@aryan-rajoria aryan-rajoria dismissed kaushikravichandran’s stale review March 16, 2023 19:01

Will be added in a different PR, as discussed.

@aryan-rajoria aryan-rajoria merged commit 619fac2 into georgia-tech-db:master Mar 16, 2023
@jarulraj jarulraj mentioned this pull request Apr 3, 2023
Merged
@aryan-rajoria aryan-rajoria deleted the catalog-doc branch May 31, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaurav274 gaurav274 gaurav274 approved these changes

@kaushikravichandran kaushikravichandran Awaiting requested review from kaushikravichandran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aryan-rajoria @gaurav274 @kaushikravichandran