Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Decorators for UDF - Part 1 #601

Merged
merged 127 commits into from
Mar 16, 2023
Merged

feat: Decorators for UDF - Part 1 #601

merged 127 commits into from
Mar 16, 2023

Conversation

IshSiva
Copy link
Contributor

@IshSiva IshSiva commented Mar 10, 2023 •
edited
Loading

Adding the feature to create UDFs using Decorators in EVA.
The decorators can be used for enforcing sanity checks on the input arguments.

Once it is fully integrated the create udf command can be like
"""
CREATE UDF IF NOT EXISTS YoloObjectDetector
IMPL eva/udfs/yolo_object_detector.py;
"""

  • Create separate classes for input types
  • Create decorators for the setup and forward functions
  • Create a custom exception class for UDF IO Errors
  • Update parser to suit the new syntax
  • Unit tests for decorators
  • Inputs for UDF decorators should be lists.

@IshSiva
created the udf service class.
93a481f
@IshSiva
Merge branch 'master' of https://github.com/georgia-tech-db/eva into …
8a37c2e 
…decorators
@IshSiva
created the decorators for udfs.
87c93d6
@IshSiva
removed old decorators implementation files
bf87ea8
@IshSiva
new implementation file for decorators
41bce38
@IshSiva
new Eva Argumet type files.
67409fb
@IshSiva
new exception type for input mismatches.
202de65
@IshSiva
renamed folder name
3a261a1
@IshSiva
removed the test_udf_service file.
32f5bca
@IshSiva
created new data types for eva
a45a404
@IshSiva
created the decorators for udfs
6adde41
@IshSiva
created a sample udf using the decorators
3152fef
@IshSiva
updates to decorators
a5f9a09
@IshSiva
changed the yolo decorators implementation
bc7ef4b
@IshSiva
fixed linting errors.
317cf75
@IshSiva
fixed linting errors.
5e92cd5
@IshSiva
added the new pandas dataframe class
1b29afd
@IshSiva
updates to decorators
423044b
@IshSiva
updated the create udf parser format.
ee60a42
@IshSiva
Added documentation.
bf58dca
@IshSiva
removed the type parameter in create udf command.
67c8204
@IshSiva
added udf type to setup decorator.
1696e9d
@IshSiva
added the tags to function signature.
0c0f322
@IshSiva
updated the decorators to do dynamic conversion.
1d9680b 
moved the exception to the errors file.
@IshSiva
added tests for udf decorators
835878b
@IshSiva
added unit tests for udf decorators.
a4f331f 
made some fixes to code
@IshSiva
Merge branch 'master' of https://github.com/georgia-tech-db/eva into …
d6a3dd2 
…decorators
@IshSiva
removed the main fn for test
1238daa
@IshSiva
linting changes
f3ce459
@IshSiva
fixed some errors in tests.
1dd961f 
linting changes.
gaurav274
gaurav274 reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@gaurav274 gaurav274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of input_format?

@suryatejreddy
Copy link
Collaborator

Can we get rid of input_format?

Done!

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@gaurav274 gaurav274 merged commit d4884d6 into master Mar 16, 2023
@gaurav274 gaurav274 deleted the decorators_1 branch March 16, 2023 15:53
@jarulraj jarulraj mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaurav274 gaurav274 gaurav274 approved these changes

@suryatejreddy suryatejreddy Awaiting requested review from suryatejreddy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IshSiva @suryatejreddy @gaurav274