feat: LIKE operator #604
Merged
feat: LIKE operator #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmitaraju
changed the title
jarulraj
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
@ashmitaraju Looks good to me. We need to create a notebook that does LICENSE plate comparison with fuzzy join (with a structured table of synthetic license plates) -- https://github.com/georgia-tech-db/license-plate-recognition
|
@aryan-rajoria I remember you mentioned a bug while using |
|
Added another test case in |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for regex-based LIKE
https://pandas.pydata.org/docs/reference/api/pandas.Series.str.match.html
Test cases
https://github.com/georgia-tech-db/eva/blob/739283677f4ac2f248d24067e479452ec958f305/eva/models/storage/batch.py#L129-L132
https://github.com/georgia-tech-db/eva/blob/78264fee1e635344f74ddacf4a31fef383c44913/test/integration_tests/test_insert_executor.py#L105-L108