Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Minor code refactor #632

Merged
merged 8 commits into from
Apr 4, 2023
Merged

fix: Minor code refactor #632

merged 8 commits into from
Apr 4, 2023

Conversation

gaurav274
Copy link
Member

@gaurav274 gaurav274 commented Apr 3, 2023 •
edited
Loading

  1. Code refactoring - improve readability fo binder and batch.py
  2. Removed deprecated append function.
  3. Fix pip install evadb by not including Dummy UDFs in the release mode.

gaurav274
gaurav274 commented Apr 4, 2023
View reviewed changes
eva/udfs/udf_bootstrap_queries.py
DummyFeatureExtractor_udf_query,
]
)
if mode != "release":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarulraj We need this for the pip install to work.

@gaurav274 gaurav274 requested a review from jarulraj April 4, 2023 15:37
@gaurav274 gaurav274 merged commit 0f41606 into master Apr 4, 2023
@gaurav274 gaurav274 deleted the minor-fixes branch April 4, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryan-rajoria aryan-rajoria aryan-rajoria approved these changes

@jarulraj jarulraj Awaiting requested review from jarulraj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaurav274 @aryan-rajoria