Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: PR reporting doesn't work when running from forks #21

Closed
georgkrause opened this issue Sep 9, 2024 · 1 comment
Closed

CI: PR reporting doesn't work when running from forks #21

georgkrause opened this issue Sep 9, 2024 · 1 comment

Comments

@georgkrause
Copy link
Owner

If someones files a PR using their own fork, which is supposed to be the normal case, the PR reporting doesn't work because Actions in forks run with read only one-time codes.

There is a pretty neat way to work around this issue documented here: https://github.com/dorny/test-reporter?tab=readme-ov-file#recommended-setup-for-public-repositories

I think I want to adopt this to try if it works with our tooling as well.

@georgkrause
Copy link
Owner Author

Sadly its not easily possible to download artifacts from "foreign" workflow runs, so this isn't really a solution here, unless we add some manual API interaction, which then would need to be maintained. So for now, we just don't have PR comments with test results and coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant