Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #14

Closed
wants to merge 1 commit into from
Closed

Fix tests #14

wants to merge 1 commit into from

Conversation

shadchin
Copy link

@shadchin shadchin commented May 9, 2024

No description provided.

@georgkrause
Copy link
Owner

@shadchin Thank you for the contribution and sorry for me not replying for a while, I have to adjust my notification settings.

Do you mind elaborating what exactly was broken before? At least in CI the tests worked even before the patch

@georgkrause
Copy link
Owner

After checking this again the problem seems to be that the test wasn't even executed before the patch. Lets see if I can fix the pipelines.

@georgkrause
Copy link
Owner

@shadchin I picked up your changes and completed the fixes in #18. Thank you a lot! Authorship of your commit is of course preserved!

@georgkrause georgkrause closed this Sep 6, 2024
@shadchin shadchin deleted the patch-1 branch September 8, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants