Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.7 docs.rs build failed #130

Closed
dead10ck opened this issue Dec 30, 2020 · 7 comments
Closed

0.7 docs.rs build failed #130

dead10ck opened this issue Dec 30, 2020 · 7 comments

Comments

@dead10ck
Copy link
Contributor

The docs.rs build for 0.7 failed: https://docs.rs/crate/gdal/0.7.0

@michaelkirk
Copy link
Member

Hopefully this will be fixed by #128 once the next release is published.

@dead10ck
Copy link
Contributor Author

Sorry, I'm not really familiar with how docs.rs works, but is there a way to fix the build without waiting for a new release? It looks like there are significant changes in 0.7 and having up to date docs would help. Also the docs published in the link in the README appear to be even older.

@michaelkirk
Copy link
Member

docs.rs is based on the published crates, so it won't be updated until the next crate version is released.

In the meanwhile, you can build the docs locally:

git clone https://github.com/georust/gdal
cd gdal
cargo doc
# on macos, or just point your browser at this file
open target/doc/gdal/index.html

@michaelkirk
Copy link
Member

Also the docs published in the link in the README appear to be even older.

Thanks for pointing this out! I've proposed a fix here: #131

@jdroenner
Copy link
Member

Thanks. I will release 0.7.1 to fix this soon.

@jdroenner
Copy link
Member

jdroenner commented Jan 3, 2021

so it turns out the fix is fine for gdal-sys but the build script of gdal still fails. i guess we will need something more complex from here: rust-lang/docs.rs#147

@jdroenner
Copy link
Member

the docs.rs build is now working 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants