Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs.rs build for gdal-sys (hopefully) #128

Merged
merged 1 commit into from
Dec 28, 2020

Conversation

michaelkirk
Copy link
Member

The gdal-sys docs are currently failing to build:
https://docs.rs/crate/gdal-sys/0.3.0/builds/326757

I think this is because the build script requires libgdal to actually be installed. This adds a short circuit to skip the normal build process and hardcodes a version of the prebuilt bindings to use when generating docs.

@michaelkirk michaelkirk changed the title fix docs.rs build for goal-sys (hopefully) fix docs.rs build for gdal-sys (hopefully) Dec 24, 2020
@michaelkirk
Copy link
Member Author

michaelkirk commented Dec 24, 2020

travis-ci build failure is same as the build failure in master:

error: no matching package named `gdal-sys` found
location searched: /home/travis/build/michaelkirk/gdal/gdal-sys
prerelease package needs to be specified explicitly
gdal-sys = { version = "0.3.1-alpha.0" }

I think it's because we're using a semantic qualifier in the constraints, which isn't compatible with "alpha" (and other prerelease) version strings.

@jdroenner
Copy link
Member

Ah yes, i guess we should remove the alpha. Cargo Release did that. Maybe we could also remove the Version from the gdal-sys dependancy.

@jdroenner jdroenner merged commit fef31b2 into georust:master Dec 28, 2020
@michaelkirk
Copy link
Member Author

Ah yes, i guess we should remove the alpha. Cargo Release did that. Maybe we could also remove the Version from the gdal-sys dependancy.

I'm not familiar with cargo release, but yeah I was surprised by the "alpha" tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants