Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clippy warnings. #630

Closed
martinfrances107 opened this issue Feb 20, 2021 · 1 comment
Closed

Remove clippy warnings. #630

martinfrances107 opened this issue Feb 20, 2021 · 1 comment

Comments

@martinfrances107
Copy link
Contributor

martinfrances107 commented Feb 20, 2021

I just want to fix a minor issue

I want to keep the main branch clear of clippy warnings -- just so when reviewing a PR any new warnings can be directly attributed to new code.

Current we have 2 warning of this form :-

I am about to create a PR to fix this.

warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
   --> geo-types/src/line_string.rs:174:5
    |
174 |     pub fn lines<'a>(&'a self) -> impl ExactSizeIterator + Iterator<Item = Line<T>> + 'a {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes

martinfrances107 added a commit to martinfrances107/geo that referenced this issue Feb 21, 2021
bors bot added a commit that referenced this issue Feb 22, 2021
631: Remove clippy warnings. #630 r=frewsxcv a=martinfrances107

- [x ] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md).
- [ x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.
---

Minor fixup: Removes clippy warnings.

Co-authored-by: Martin <martinfrances107@hotmail.com>
@frewsxcv
Copy link
Member

#631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants