Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector2DOps fixes #1051

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Vector2DOps fixes #1051

merged 6 commits into from
Aug 8, 2023

Conversation

thehappycheese
Copy link
Contributor

@thehappycheese thehappycheese commented Aug 8, 2023

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.
  • ran cargo fmt then cargo fmt --all -- --check
  • ran cargo clippy --all-features --all-targets -- -Dwarnings

Fixing some derps in my previous PR :)

  • Removed Send + Sync from Scalar type; as far as I can tell these constraints are only needed if the trait uses threads. Removing Send+Sync should not prevent a user from using the trait with a Send+Sync type.
  • Switched to cmath::hypot for magnitude() for instant gain in robustness, and fixed tests to reflect

@thehappycheese thehappycheese marked this pull request as ready for review August 8, 2023 14:31
@michaelkirk
Copy link
Member

Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 8, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

  • ci result

@bors bors bot merged commit dea43d2 into georust:main Aug 8, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants