Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cargo-tarpaulin due to instability #677

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Remove cargo-tarpaulin due to instability #677

merged 2 commits into from
Nov 4, 2021

Conversation

urschrei
Copy link
Member

@urschrei urschrei commented Nov 3, 2021

See discussion at #676

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

michaelkirk
michaelkirk approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but maybe leave it open for a bit in case others have input?

@urschrei
Copy link
Member Author

urschrei commented Nov 3, 2021

@frewsxcv and @lnicola WDYT?
@rmanoka I saw a 👍 from you yesterday…

lnicola
lnicola approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@lnicola lnicola left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tarpaulin is nice, but finicky like this. I don't think keeping it is worth the hassle.

@rmanoka
Copy link
Contributor

rmanoka commented Nov 3, 2021

Yes, I agree about removing tarpaulin. I could never get it running locally, so I also never found it super robust.

@urschrei
Copy link
Member Author

urschrei commented Nov 4, 2021

Bors r+

@bors
Copy link
Contributor

bors bot commented Nov 4, 2021

Build succeeded:

@bors bors bot merged commit 7af4f80 into georust:master Nov 4, 2021
@urschrei urschrei deleted the remove_tarpaulin branch November 4, 2021 07:43
@lnicola lnicola mentioned this pull request Nov 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv frewsxcv approved these changes

@lnicola lnicola lnicola approved these changes

@michaelkirk michaelkirk michaelkirk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@urschrei @rmanoka @michaelkirk @lnicola @frewsxcv